Skip to content

fix(openapi): resolve schema generation failures#741

Merged
TylerAdamMartinez merged 2 commits into
stagingfrom
fix/general-types-fix
Jun 25, 2026
Merged

fix(openapi): resolve schema generation failures#741
TylerAdamMartinez merged 2 commits into
stagingfrom
fix/general-types-fix

Conversation

@TylerAdamMartinez

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem/context:

  • Fixes OpenAPI generation failures caused by dependency aliases being typed incorrectly.
  • Prevents OpenAPI customization logic from crashing when app.routes contains non-route router objects.

How

Implementation summary - the following was changed/added/removed:

  • Updated shared dependency aliases in core/dependencies.py to use TypeAlias instead of type[...].
  • Updated the OpenAPI route lookup in core/app.py to safely access path and methods using getattr().

Notes

Any special considerations, workarounds, or follow-up work to note?

  • This should resolve the _IncludedRouter attribute error during /openapi.json generation.
  • Verify by running the app locally and confirming /docs and /openapi.json both load successfully.

@TylerAdamMartinez TylerAdamMartinez merged commit 89bb35b into staging Jun 25, 2026
7 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the fix/general-types-fix branch June 25, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants